Commit dfd3a4d
build: add flag to enable pointer compression
The --experimental-enable-pointer-compression is experimental
as it breaks ABI compatibility.
PR-URL: #30463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent de36820 commit dfd3a4d
3 files changed
Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,9 +73,6 @@ | |||
| 73 | 73 | # TODO(refack): make v8-perfetto happen | |
| 74 | 74 | 'v8_use_perfetto': 0, | |
| 75 | 75 | ||
| 76 | - 'v8_enable_pointer_compression': 0, | ||
| 77 | - 'v8_enable_31bit_smis_on_64bit_arch': 0, | ||
| 78 | - | ||
| 79 | 76 | ##### end V8 defaults ##### | |
| 80 | 77 | ||
| 81 | 78 | 'conditions': [ | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -346,6 +346,11 @@ | |||
| 346 | 346 | dest='trace_maps', | |
| 347 | 347 | help='Enable the --trace-maps flag in V8 (use at your own risk)') | |
| 348 | 348 | ||
| 349 | + parser.add_option('--experimental-enable-pointer-compression', | ||
| 350 | + action='store_true', | ||
| 351 | + dest='enable_pointer_compression', | ||
| 352 | + help='[Experimental] Enable V8 pointer compression (limits max heap to 4GB and breaks ABI compatibility)') | ||
| 353 | + | ||
| 349 | 354 | parser.add_option('--v8-options', | |
| 350 | 355 | action='store', | |
| 351 | 356 | dest='v8_options', | |
@@ -1192,6 +1197,8 @@ def configure_v8(o): | |||
| 1192 | 1197 | o['variables']['v8_random_seed'] = 0 # Use a random seed for hash tables. | |
| 1193 | 1198 | o['variables']['v8_promise_internal_field_count'] = 1 # Add internal field to promises for async hooks. | |
| 1194 | 1199 | o['variables']['v8_use_siphash'] = 0 if options.without_siphash else 1 | |
| 1200 | + o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0 | ||
| 1201 | + o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0 | ||
| 1195 | 1202 | o['variables']['v8_trace_maps'] = 1 if options.trace_maps else 0 | |
| 1196 | 1203 | o['variables']['node_use_v8_platform'] = b(not options.without_v8_platform) | |
| 1197 | 1204 | o['variables']['node_use_bundled_v8'] = b(not options.without_bundled_v8) | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,6 +2,8 @@ | |||
| 2 | 2 | 'variables': { | |
| 3 | 3 | 'v8_use_siphash%': 0, | |
| 4 | 4 | 'v8_trace_maps%': 0, | |
| 5 | + 'v8_enable_pointer_compression%': 0, | ||
| 6 | + 'v8_enable_31bit_smis_on_64bit_arch%': 0, | ||
| 5 | 7 | 'node_use_dtrace%': 'false', | |
| 6 | 8 | 'node_use_etw%': 'false', | |
| 7 | 9 | 'node_no_browser_globals%': 'false', | |
0 commit comments