Commit dfdf742
util: use Set to store deprecation codes
PR-URL: #28113
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent e6ecc13 commit dfdf742
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -35,7 +35,7 @@ function isError(e) { | |||
| 35 | 35 | ||
| 36 | 36 | // Keep a list of deprecation codes that have been warned on so we only warn on | |
| 37 | 37 | // each one once. | |
| 38 | - const codesWarned = {}; | ||
| 38 | + const codesWarned = new Set(); | ||
| 39 | 39 | ||
| 40 | 40 | // Mark that a method should not be used. | |
| 41 | 41 | // Returns a modified function which warns once by default. | |
@@ -53,9 +53,9 @@ function deprecate(fn, msg, code) { | |||
| 53 | 53 | if (!warned) { | |
| 54 | 54 | warned = true; | |
| 55 | 55 | if (code !== undefined) { | |
| 56 | - if (!codesWarned[code]) { | ||
| 56 | + if (!codesWarned.has(code)) { | ||
| 57 | 57 | process.emitWarning(msg, 'DeprecationWarning', code, deprecated); | |
| 58 | - codesWarned[code] = true; | ||
| 58 | + codesWarned.add(code); | ||
| 59 | 59 | } | |
| 60 | 60 | } else { | |
| 61 | 61 | process.emitWarning(msg, 'DeprecationWarning', deprecated); | |
0 commit comments