test: skip url WPT subtests instead of modifying test script · nodejs/node@e04e2c9 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e04e2c9

Browse filesBrowse the repository at this point in the historyBrowse files

panva

authored and

aduh95

committed

test: skip url WPT subtests instead of modifying test script

Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #62635 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 29b1966 commit e04e2c9
Copy full SHA for e04e2c9

3 files changed

+25-26Lines changed: 25 additions & 26 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/wpt
  • status
    • url.cjs
    • url.json
  • test-url.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/wpt/status/url.cjs‎

Copy file name to clipboard

+25Lines changed: 25 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,25 @@
	1	+ 'use strict';
	2	+
	3	+ module.exports = {
	4	+ 'historical.any.js': {
	5	+ 'fail': {
	6	+ 'expected': [
	7	+ 'searchParams on location object',
	8	+ ],
	9	+ },
	10	+ },
	11	+ 'javascript-urls.window.js': {
	12	+ 'skip': 'requires document.body reference',
	13	+ },
	14	+ 'percent-encoding.window.js': {
	15	+ 'skip': 'requires document.body reference',
	16	+ },
	17	+ 'toascii.window.js': {
	18	+ 'skipTests': [
	19	+ /\(using <a(rea)?>/,
	20	+ ],
	21	+ },
	22	+ 'url-setters-a-area.window.js': {
	23	+ 'skip': 'already tested in url-setters.any.js',
	24	+ },
	25	+ };

Collapse file

‎test/wpt/status/url.json‎

Copy file name to clipboardExpand all lines: test/wpt/status/url.json

-18Lines changed: 0 additions & 18 deletions

This file was deleted.

Collapse file

‎test/wpt/test-url.js‎

Copy file name to clipboardExpand all lines: test/wpt/test-url.js

-8Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -10,13 +10,5 @@ const { WPTRunner } = require('../common/wpt');
10	10
11	11	const runner = new WPTRunner('url');
12	12
13		- runner.setScriptModifier((obj) => {
14		- if (obj.filename.includes('toascii.window.js')) {
15		- // `a` and `area` in `toascii.window.js` is for testing `Element` that
16		- // created via `document.createElement`. So we need to ignore them and just
17		- // test `URL`.
18		- obj.code = obj.code.replace(/\["url", "a", "area"\]/, '[ "url" ]');
19		- }
20		- });
21	13	runner.pretendGlobalThisAs('Window');
22	14	runner.runJsTests();

0 commit comments

Comments

0 (0)