Commit e05bb40
tools: lint for spacing around unary operators
Enable `space-unary-ops` in `.eslintrc`. This prohibits things like:
i ++ // use `i++` instead
typeof(foo) // use `typeof foo` or `typeof (foo)` instead
Ref: #4772 (comment)
PR-URL: #5063
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 6363264 commit e05bb40
17 files changed
Lines changed: 20 additions & 18 deletions
File tree
- lib
- test
- gc
- parallel
- sequential
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -81,6 +81,8 @@ rules: | |||
| 81 | 81 | space-after-keywords: 2 | |
| 82 | 82 | ## no leading/trailing spaces in parens | |
| 83 | 83 | space-in-parens: [2, "never"] | |
| 84 | + ## no spaces with non-word unary operators, require for word unary operators | ||
| 85 | + space-unary-ops: 2 | ||
| 84 | 86 | ||
| 85 | 87 | # ECMAScript 6 | |
| 86 | 88 | # list: http://eslint.org/docs/rules/#ecmascript-6 | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -318,7 +318,7 @@ function unrefdHandle() { | |||
| 318 | 318 | Timeout.prototype.unref = function() { | |
| 319 | 319 | if (this._handle) { | |
| 320 | 320 | this._handle.unref(); | |
| 321 | - } else if (typeof(this._onTimeout) === 'function') { | ||
| 321 | + } else if (typeof this._onTimeout === 'function') { | ||
| 322 | 322 | var now = Timer.now(); | |
| 323 | 323 | if (!this._idleStart) this._idleStart = now; | |
| 324 | 324 | var delay = this._idleStart + this._idleTimeout - now; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -48,7 +48,7 @@ for (var i = 0; i < 10; i++) | |||
| 48 | 48 | getall(); | |
| 49 | 49 | ||
| 50 | 50 | function afterGC() { | |
| 51 | - countGC ++; | ||
| 51 | + countGC++; | ||
| 52 | 52 | } | |
| 53 | 53 | ||
| 54 | 54 | var timer; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -56,7 +56,7 @@ function runTest() { | |||
| 56 | 56 | } | |
| 57 | 57 | ||
| 58 | 58 | function afterGC() { | |
| 59 | - countGC ++; | ||
| 59 | + countGC++; | ||
| 60 | 60 | } | |
| 61 | 61 | ||
| 62 | 62 | var timer; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -57,7 +57,7 @@ for (var i = 0; i < 10; i++) | |||
| 57 | 57 | getall(); | |
| 58 | 58 | ||
| 59 | 59 | function afterGC() { | |
| 60 | - countGC ++; | ||
| 60 | + countGC++; | ||
| 61 | 61 | } | |
| 62 | 62 | ||
| 63 | 63 | var timer; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -51,7 +51,7 @@ for (var i = 0; i < 10; i++) | |||
| 51 | 51 | getall(); | |
| 52 | 52 | ||
| 53 | 53 | function afterGC() { | |
| 54 | - countGC ++; | ||
| 54 | + countGC++; | ||
| 55 | 55 | } | |
| 56 | 56 | ||
| 57 | 57 | setInterval(status, 1000).unref(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -57,7 +57,7 @@ for (var i = 0; i < 10; i++) | |||
| 57 | 57 | getall(); | |
| 58 | 58 | ||
| 59 | 59 | function afterGC() { | |
| 60 | - countGC ++; | ||
| 60 | + countGC++; | ||
| 61 | 61 | } | |
| 62 | 62 | ||
| 63 | 63 | setInterval(status, 100).unref(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -10,8 +10,8 @@ var str = 'hello'; | |||
| 10 | 10 | ||
| 11 | 11 | // default encoding | |
| 12 | 12 | exec('echo ' + str, function(err, stdout, stderr) { | |
| 13 | - assert.ok('string', typeof(stdout), 'Expected stdout to be a string'); | ||
| 14 | - assert.ok('string', typeof(stderr), 'Expected stderr to be a string'); | ||
| 13 | + assert.ok('string', typeof stdout, 'Expected stdout to be a string'); | ||
| 14 | + assert.ok('string', typeof stderr, 'Expected stderr to be a string'); | ||
| 15 | 15 | assert.equal(str + os.EOL, stdout); | |
| 16 | 16 | ||
| 17 | 17 | success_count++; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,7 +55,7 @@ file.on('close', function() { | |||
| 55 | 55 | var file3 = fs.createReadStream(fn, Object.create({encoding: 'utf8'})); | |
| 56 | 56 | file3.length = 0; | |
| 57 | 57 | file3.on('data', function(data) { | |
| 58 | - assert.equal('string', typeof(data)); | ||
| 58 | + assert.equal('string', typeof data); | ||
| 59 | 59 | file3.length += data.length; | |
| 60 | 60 | ||
| 61 | 61 | for (var i = 0; i < data.length; i++) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -55,7 +55,7 @@ file.on('close', function() { | |||
| 55 | 55 | var file3 = fs.createReadStream(fn, {encoding: 'utf8'}); | |
| 56 | 56 | file3.length = 0; | |
| 57 | 57 | file3.on('data', function(data) { | |
| 58 | - assert.equal('string', typeof(data)); | ||
| 58 | + assert.equal('string', typeof data); | ||
| 59 | 59 | file3.length += data.length; | |
| 60 | 60 | ||
| 61 | 61 | for (var i = 0; i < data.length; i++) { | |
0 commit comments