bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose} · nodejs/node@e08fd98 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e08fd98

Browse filesBrowse the repository at this point in the historyBrowse files

ljharb

authored and

targos

committed

bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose}

Followup to #48518; fixes #48699 PR-URL: #48703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 67925bb commit e08fd98
Copy full SHA for e08fd98

1 file changed

+19-2Lines changed: 19 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/process
  • pre_execution.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/process/pre_execution.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/pre_execution.js

+19-2Lines changed: 19 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -120,9 +120,26 @@ function prepareExecution(options) {
120	120	function setupSymbolDisposePolyfill() {
121	121	// TODO(MoLow): Remove this polyfill once Symbol.dispose and Symbol.asyncDispose are available in V8.
122	122	// eslint-disable-next-line node-core/prefer-primordials
123		- Symbol.dispose ??= SymbolDispose;
	123	+ if (typeof Symbol.dispose !== 'symbol') {
	124	+ ObjectDefineProperty(Symbol, 'dispose', {
	125	+ __proto__: null,
	126	+ configurable: false,
	127	+ enumerable: false,
	128	+ value: SymbolDispose,
	129	+ writable: false,
	130	+ });
	131	+ }
	132	+
124	133	// eslint-disable-next-line node-core/prefer-primordials
125		- Symbol.asyncDispose ??= SymbolAsyncDispose;
	134	+ if (typeof Symbol.asyncDispose !== 'symbol') {
	135	+ ObjectDefineProperty(Symbol, 'asyncDispose', {
	136	+ __proto__: null,
	137	+ configurable: false,
	138	+ enumerable: false,
	139	+ value: SymbolAsyncDispose,
	140	+ writable: false,
	141	+ });
	142	+ }
126	143	}
127	144
128	145	function setupUserModules(isLoaderWorker = false) {

0 commit comments

Comments

0 (0)