Commit e0dc0ce
build: don't squash signal handlers with --shared
An application using node built as a shared library may legitimately
implement its own signal handling routines. Current behaviour is
to squash all signal handlers on node startup. This change will
stop that behaviour when node is built as a shared library.
PR-URL: #10539
Fixes: #10520
Refs: #615
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 3516f35 commit e0dc0ce
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3957,6 +3957,7 @@ inline void PlatformInit() { | |||
| 3957 | 3957 | ||
| 3958 | 3958 | CHECK_EQ(err, 0); | |
| 3959 | 3959 | ||
| 3960 | + #ifndef NODE_SHARED_MODE | ||
| 3960 | 3961 | // Restore signal dispositions, the parent process may have changed them. | |
| 3961 | 3962 | struct sigaction act; | |
| 3962 | 3963 | memset(&act, 0, sizeof(act)); | |
@@ -3970,6 +3971,7 @@ inline void PlatformInit() { | |||
| 3970 | 3971 | act.sa_handler = (nr == SIGPIPE) ? SIG_IGN : SIG_DFL; | |
| 3971 | 3972 | CHECK_EQ(0, sigaction(nr, &act, nullptr)); | |
| 3972 | 3973 | } | |
| 3974 | + #endif // !NODE_SHARED_MODE | ||
| 3973 | 3975 | ||
| 3974 | 3976 | RegisterSignalHandler(SIGINT, SignalExit, true); | |
| 3975 | 3977 | RegisterSignalHandler(SIGTERM, SignalExit, true); | |
0 commit comments