events: improve `addAbortListener` perf by caching options object · nodejs/node@e0f211c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e0f211c

Browse filesBrowse the repository at this point in the historyBrowse files

rluvaton

authored and

aduh95

committed

events: improve addAbortListener perf by caching options object

PR-URL: #52367 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 206c1b8 commit e0f211c
Copy full SHA for e0f211c

1 file changed

+4-1Lines changed: 4 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/events
  • abort_listener.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/events/abort_listener.js‎

Copy file name to clipboardExpand all lines: lib/internal/events/abort_listener.js

+4-1Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,7 @@
1	1	'use strict';
2	2
3	3	const {
	4	+ ObjectFreeze,
4	5	SymbolDispose,
5	6	} = primordials;
6	7	const {
@@ -15,6 +16,7 @@ const {
15	16
16	17	let queueMicrotask;
17	18	let kResistStopPropagation;
	19	+ let abortListenerOptions;
18	20
19	21	/**
20	22	* @param {AbortSignal} signal
@@ -34,8 +36,9 @@ function addAbortListener(signal, listener) {
34	36	queueMicrotask(() => listener());
35	37	} else {
36	38	kResistStopPropagation ??= require('internal/event_target').kResistStopPropagation;
	39	+ abortListenerOptions ??= ObjectFreeze({ __proto__: null, once: true, [kResistStopPropagation]: true });
37	40	// TODO(atlowChemi) add { subscription: true } and return directly
38		- signal.addEventListener('abort', listener, { __proto__: null, once: true, [kResistStopPropagation]: true });
	41	+ signal.addEventListener('abort', listener, abortListenerOptions);
39	42	removeEventListener = () => {
40	43	signal.removeEventListener('abort', listener);
41	44	};

0 commit comments

Comments

0 (0)