Commit e1007ff
src: remove dead comments about return_code_cache
This behavior of sometimes returning the function & other times
returning the code cache was removed a long time ago in the referenced
PR, as evinced by the return type `MaybeLocal<Function>`. Remove these
incorrect comments.
Refs: #24950
PR-URL: #47083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent e668efa commit e1007ff
1 file changed
Lines changed: 3 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -261,9 +261,6 @@ bool BuiltinLoader::Add(const char* id, std::string_view utf8source) { | |||
| 261 | 261 | return Add(id, UnionBytes(out)); | |
| 262 | 262 | } | |
| 263 | 263 | ||
| 264 | - // Returns Local<Function> of the compiled module if return_code_cache | ||
| 265 | - // is false (we are only compiling the function). | ||
| 266 | - // Otherwise return a Local<Object> containing the cache. | ||
| 267 | 264 | MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal( | |
| 268 | 265 | Local<Context> context, | |
| 269 | 266 | const char* id, | |
@@ -368,11 +365,9 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal( | |||
| 368 | 365 | return scope.Escape(fun); | |
| 369 | 366 | } | |
| 370 | 367 | ||
| 371 | - // Returns Local<Function> of the compiled module if return_code_cache | ||
| 372 | - // is false (we are only compiling the function). | ||
| 373 | - // Otherwise return a Local<Object> containing the cache. | ||
| 374 | - MaybeLocal<Function> BuiltinLoader::LookupAndCompile( | ||
| 375 | - Local<Context> context, const char* id, Environment* optional_env) { | ||
| 368 | + MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context, | ||
| 369 | + const char* id, | ||
| 370 | + Environment* optional_env) { | ||
| 376 | 371 | Result result; | |
| 377 | 372 | std::vector<Local<String>> parameters; | |
| 378 | 373 | Isolate* isolate = context->GetIsolate(); | |
0 commit comments