Commit e122d39
test: replace setTimeout with setImmediate in stream test
Replace setTimeout() with setImmediate() in
test-stream-writable-clear-buffer. The test still fails in Node.js 8.6.0
(if you comment out the `common` module, since it uses BigInts and those
aren't supported in 8.6.0).
PR-URL: #30561
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 8ef629a commit e122d39
1 file changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,5 +1,5 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - const common = require('../common'); | ||
| 2 | + require('../common'); | ||
| 3 | 3 | const Stream = require('stream'); | |
| 4 | 4 | // This test ensures that the _writeableState.bufferedRequestCount and | |
| 5 | 5 | // the actual buffered request count are the same | |
@@ -10,11 +10,12 @@ class StreamWritable extends Stream.Writable { | |||
| 10 | 10 | super({ objectMode: true }); | |
| 11 | 11 | } | |
| 12 | 12 | ||
| 13 | - // We need a timeout like on the original issue thread | ||
| 14 | - // otherwise the code will never reach our test case | ||
| 15 | - // this means this should go on the sequential folder. | ||
| 13 | + // Refs: https://github.com/nodejs/node/issues/6758 | ||
| 14 | + // We need a timer like on the original issue thread. | ||
| 15 | + // Otherwise the code will never reach our test case. | ||
| 16 | + // This means this should go in the sequential folder. | ||
| 16 | 17 | _write(chunk, encoding, cb) { | |
| 17 | - setTimeout(cb, common.platformTimeout(10)); | ||
| 18 | + setImmediate(cb); | ||
| 18 | 19 | } | |
| 19 | 20 | } | |
| 20 | 21 | ||
0 commit comments