benchmark: remove excessive value from http2 benchmark · nodejs/node@e136903 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e136903

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

committed

benchmark: remove excessive value from http2 benchmark

`requests = 1000000` took about 10 minutes per run for me and doesn’t seem to add much value on its own. PR-URL: #18936 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

1 parent d93c48b commit e136903
Copy full SHA for e136903

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• benchmark/http2
  • respond-with-fd.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎benchmark/http2/respond-with-fd.js‎

Copy file name to clipboardExpand all lines: benchmark/http2/respond-with-fd.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -7,7 +7,7 @@ const fs = require('fs');
7	7	const file = path.join(path.resolve(__dirname, '../fixtures'), 'alice.html');
8	8
9	9	const bench = common.createBenchmark(main, {
10		- requests: [100, 1000, 10000, 100000, 1000000],
	10	+ requests: [100, 1000, 10000, 100000],
11	11	streams: [100, 200, 1000],
12	12	clients: [1, 2],
13	13	benchmarker: ['h2load']

0 commit comments

Comments

0 (0)