Commit e14f864
lib,test: remove lib/internal/test/unicode.js
Remove lib/internal/test/unicode.js and associated test. When we added
the file and test, only comments in lib had non-ASCII characters. Now,
lib/internal/cli_table.js has non-ASCII characters. Tests that exercise
the `console.table()` therefore fulfill the need to test non-ASCII
characters in built-in modules.
PR-URL: #25298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 9101591 commit e14f864
4 files changed
Lines changed: 6 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,6 +4,12 @@ const { Buffer } = require('buffer'); | |||
| 4 | 4 | const { removeColors } = require('internal/util'); | |
| 5 | 5 | const HasOwnProperty = Function.call.bind(Object.prototype.hasOwnProperty); | |
| 6 | 6 | ||
| 7 | + // The use of Unicode characters below is the only non-comment use of non-ASCII | ||
| 8 | + // Unicode characters in Node.js built-in modules. If they are ever removed or | ||
| 9 | + // rewritten with \u escapes, then a test will need to be (re-)added to Node.js | ||
| 10 | + // core to verify that Unicode characters work in built-ins. Otherwise, | ||
| 11 | + // consumers using Unicode in _third_party_main.js will run into problems. | ||
| 12 | + // Refs: https://github.com/nodejs/node/issues/10673 | ||
| 7 | 13 | const tableChars = { | |
| 8 | 14 | /* eslint-disable node-core/non-ascii-character */ | |
| 9 | 15 | middleMiddle: '─', | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -159,7 +159,6 @@ | |||
| 159 | 159 | 'lib/internal/socket_list.js', | |
| 160 | 160 | 'lib/internal/test/binding.js', | |
| 161 | 161 | 'lib/internal/test/heap.js', | |
| 162 | - 'lib/internal/test/unicode.js', | ||
| 163 | 162 | 'lib/internal/timers.js', | |
| 164 | 163 | 'lib/internal/tls.js', | |
| 165 | 164 | 'lib/internal/trace_events_async_hooks.js', | |
This file was deleted.
0 commit comments