src: run RunBeforeExitCallbacks as part of EmitBeforeExit · nodejs/node@e1a1244 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e1a1244

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

MylesBorins

committed

src: run RunBeforeExitCallbacks as part of EmitBeforeExit

This is part of a series of changes to make embedding easier, by requiring fewer internal methods to build a fully functioning Node.js instance. This also aligns the worker_threads code with the main thread code. PR-URL: #30229 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

1 parent da8ceb9 commit e1a1244
Copy full SHA for e1a1244

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • api
    • hooks.cc
  • node_main_instance.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/api/hooks.cc‎

Copy file name to clipboardExpand all lines: src/api/hooks.cc

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -30,6 +30,8 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) {
30	30	}
31	31
32	32	void EmitBeforeExit(Environment* env) {
	33	+ env->RunBeforeExitCallbacks();
	34	+
33	35	HandleScope handle_scope(env->isolate());
34	36	Context::Scope context_scope(env->context());
35	37	Local<Value> exit_code = env->process_object()

Collapse file

‎src/node_main_instance.cc‎

Copy file name to clipboardExpand all lines: src/node_main_instance.cc

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -133,8 +133,6 @@ int NodeMainInstance::Run() {
133	133	more = uv_loop_alive(env->event_loop());
134	134	if (more && !env->is_stopping()) continue;
135	135
136		- env->RunBeforeExitCallbacks();
137		-
138	136	if (!uv_loop_alive(env->event_loop())) {
139	137	EmitBeforeExit(env.get());
140	138	}

0 commit comments

Comments

0 (0)