test: remove flaky designation for test_threadsafe_function · nodejs/node@e1aa510 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e1aa510

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

BridgeAR

committed

test: remove flaky designation for test_threadsafe_function

The test_threadsafe_function doesn't seem to be flaky anymore on Windows. Optimistically removing the flaky designation in the relevant status file. Refs: #23621 (comment) PR-URL: #26403 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent dc4258a commit e1aa510
Copy full SHA for e1aa510

1 file changed

-2Lines changed: 0 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/node-api
  • node-api.status

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/node-api/node-api.status‎

Copy file name to clipboardExpand all lines: test/node-api/node-api.status

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -7,5 +7,3 @@ prefix node-api
7	7	[true] # This section applies to all platforms
8	8
9	9	[$system==win32]
10		- # https://github.com/nodejs/node/issues/23621
11		- test_threadsafe_function/test: PASS,FLAKY

0 commit comments

Comments

0 (0)