Commit e1ae61b
policy: revise manifest.js to avoid empty blocks
PR-URL: #41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 4834be3 commit e1ae61b
1 file changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -430,12 +430,11 @@ class Manifest { | |||
| 430 | 430 | ||
| 431 | 431 | if (objectButNotArray(obj) && 'onerror' in obj) { | |
| 432 | 432 | const behavior = obj.onerror; | |
| 433 | - if (behavior === 'throw') { | ||
| 434 | - } else if (behavior === 'exit') { | ||
| 433 | + if (behavior === 'exit') { | ||
| 435 | 434 | reaction = REACTION_EXIT; | |
| 436 | 435 | } else if (behavior === 'log') { | |
| 437 | 436 | reaction = REACTION_LOG; | |
| 438 | - } else { | ||
| 437 | + } else if (behavior !== 'throw') { | ||
| 439 | 438 | throw new ERR_MANIFEST_UNKNOWN_ONERROR(behavior); | |
| 440 | 439 | } | |
| 441 | 440 | } | |
@@ -579,8 +578,7 @@ class Manifest { | |||
| 579 | 578 | const entry = this.#scopeIntegrities.get(scope); | |
| 580 | 579 | if (entry === true) { | |
| 581 | 580 | return true; | |
| 582 | - } else if (entry === kCascade) { | ||
| 583 | - } else { | ||
| 581 | + } else if (entry !== kCascade) { | ||
| 584 | 582 | break; | |
| 585 | 583 | } | |
| 586 | 584 | } | |
0 commit comments