Commit e1f7d68
benchmark: use boolean options in benchmark tests
Use boolean values for randomUUID benchmark and
deprecate benchmark instead of 0/1.
PR-URL: #60129
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>1 parent 91127c9 commit e1f7d68
2 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,11 +5,10 @@ const { randomUUID } = require('crypto'); | |||
| 5 | 5 | ||
| 6 | 6 | const bench = common.createBenchmark(main, { | |
| 7 | 7 | n: [1e7], | |
| 8 | - disableEntropyCache: [0, 1], | ||
| 8 | + disableEntropyCache: [false, true], | ||
| 9 | 9 | }); | |
| 10 | 10 | ||
| 11 | 11 | function main({ n, disableEntropyCache }) { | |
| 12 | - disableEntropyCache = !!disableEntropyCache; | ||
| 13 | 12 | bench.start(); | |
| 14 | 13 | for (let i = 0; i < n; ++i) | |
| 15 | 14 | randomUUID({ disableEntropyCache }); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,7 +5,7 @@ const assert = require('assert'); | |||
| 5 | 5 | ||
| 6 | 6 | const bench = common.createBenchmark(main, { | |
| 7 | 7 | n: [1e5], | |
| 8 | - modifyPrototype: [1, 0], | ||
| 8 | + modifyPrototype: [true, false], | ||
| 9 | 9 | emitWarningSync: [1, 0], | |
| 10 | 10 | }, { | |
| 11 | 11 | flags: ['--expose-internals'], | |
@@ -23,7 +23,7 @@ function main({ n, modifyPrototype, emitWarningSync }) { | |||
| 23 | 23 | 'This function is deprecated', | |
| 24 | 24 | 'DEP0000', | |
| 25 | 25 | emitWarningSync, | |
| 26 | - !!modifyPrototype, | ||
| 26 | + modifyPrototype, | ||
| 27 | 27 | ); | |
| 28 | 28 | ||
| 29 | 29 | let sum = 0; | |
0 commit comments