Commit e2668c0
test_runner: print failing assertion only once with spec reporter
Co-authored-by: Llorx <dallorx@gmail.com>
PR-URL: #56662
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 8f59f5b commit e2668c0
8 files changed
Lines changed: 5 additions & 782 deletions
File tree
- lib/internal/test_runner/reporter
- test/fixtures/test-runner/output
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -52,7 +52,7 @@ class SpecReporter extends Transform { | |||
| 52 | 52 | hasChildren = true; | |
| 53 | 53 | } | |
| 54 | 54 | const indentation = indent(data.nesting); | |
| 55 | - return `${formatTestReport(type, data, prefix, indentation, hasChildren)}\n`; | ||
| 55 | + return `${formatTestReport(type, data, prefix, indentation, hasChildren, false)}\n`; | ||
| 56 | 56 | } | |
| 57 | 57 | #handleEvent({ type, data }) { | |
| 58 | 58 | switch (type) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -59,7 +59,7 @@ function formatError(error, indent) { | |||
| 59 | 59 | return `\n${indent} ${message}\n`; | |
| 60 | 60 | } | |
| 61 | 61 | ||
| 62 | - function formatTestReport(type, data, prefix = '', indent = '', hasChildren = false) { | ||
| 62 | + function formatTestReport(type, data, prefix = '', indent = '', hasChildren = false, showErrorDetails = true) { | ||
| 63 | 63 | let color = reporterColorMap[type] ?? colors.white; | |
| 64 | 64 | let symbol = reporterUnicodeSymbolMap[type] ?? ' '; | |
| 65 | 65 | const { skip, todo } = data; | |
@@ -71,10 +71,12 @@ function formatTestReport(type, data, prefix = '', indent = '', hasChildren = fa | |||
| 71 | 71 | } else if (todo !== undefined) { | |
| 72 | 72 | title += ` # ${typeof todo === 'string' && todo.length ? todo : 'TODO'}`; | |
| 73 | 73 | } | |
| 74 | - const error = formatError(data.details?.error, indent); | ||
| 74 | + | ||
| 75 | + const error = showErrorDetails ? formatError(data.details?.error, indent) : ''; | ||
| 75 | 76 | const err = hasChildren ? | |
| 76 | 77 | (!error || data.details?.error?.failureType === 'subtestsFailed' ? '' : `\n${error}`) : | |
| 77 | 78 | error; | |
| 79 | + | ||
| 78 | 80 | if (skip !== undefined) { | |
| 79 | 81 | color = colors.gray; | |
| 80 | 82 | symbol = reporterUnicodeSymbolMap['hyphen:minus']; | |
Lines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,16 +1,4 @@ | |||
| 1 | 1 | [31m✖ failing assertion [90m(*ms)[39m[39m | |
| 2 | - [AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: | ||
| 3 | - [32mactual[39m [31mexpected[39m | ||
| 4 | - | ||
| 5 | - [39m'[39m[32m![39m[39mH[39m[39me[39m[39ml[39m[39ml[39m[39mo[39m[39m [39m[39mW[39m[39mo[39m[39mr[39m[39ml[39m[39md[39m[31m![39m[39m'[39m | ||
| 6 | - ] { | ||
| 7 | - generatedMessage: [33mtrue[39m, | ||
| 8 | - code: [32m'ERR_ASSERTION'[39m, | ||
| 9 | - actual: [32m'!Hello World'[39m, | ||
| 10 | - expected: [32m'Hello World!'[39m, | ||
| 11 | - operator: [32m'strictEqual'[39m | ||
| 12 | - } | ||
| 13 | - | ||
| 14 | 2 | [34mℹ tests 1[39m | |
| 15 | 3 | [34mℹ suites 0[39m | |
| 16 | 4 | [34mℹ pass 0[39m | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,32 +1,9 @@ | |||
| 1 | 1 | [32m✔ should pass [90m(*ms)[39m[39m | |
| 2 | 2 | [31m✖ should fail [90m(*ms)[39m[39m | |
| 3 | - Error: fail | ||
| 4 | - *[39m | ||
| 5 | - *[39m | ||
| 6 | - *[39m | ||
| 7 | - *[39m | ||
| 8 | - *[39m | ||
| 9 | - *[39m | ||
| 10 | - *[39m | ||
| 11 | - | ||
| 12 | 3 | [90m﹣ should skip [90m(*ms)[39m # SKIP[39m | |
| 13 | 4 | ▶ parent | |
| 14 | 5 | [31m✖ should fail [90m(*ms)[39m[39m | |
| 15 | - Error: fail | ||
| 16 | - *[39m | ||
| 17 | - *[39m | ||
| 18 | - *[39m | ||
| 19 | - *[39m | ||
| 20 | - *[39m | ||
| 21 | - *[39m | ||
| 22 | - *[39m | ||
| 23 | - *[39m | ||
| 24 | - *[39m | ||
| 25 | - *[39m | ||
| 26 | - | ||
| 27 | 6 | [31m✖ should pass but parent fail [90m(*ms)[39m[39m | |
| 28 | - [32m'test did not finish before its parent and was cancelled'[39m | ||
| 29 | - | ||
| 30 | 7 | [31m✖ parent [90m(*ms)[39m[39m | |
| 31 | 8 | [34mℹ tests 6[39m | |
| 32 | 9 | [34mℹ suites 0[39m | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,14 +1,5 @@ | |||
| 1 | 1 | ✔ passes (*ms) | |
| 2 | 2 | ✖ fails (*ms) | |
| 3 | - Error: fail | ||
| 4 | - * | ||
| 5 | - * | ||
| 6 | - * | ||
| 7 | - * | ||
| 8 | - * | ||
| 9 | - * | ||
| 10 | - * | ||
| 11 | - | ||
| 12 | 3 | ℹ tests 2 | |
| 13 | 4 | ℹ suites 0 | |
| 14 | 5 | ℹ pass 1 | |
0 commit comments