Commit e2ced0d
perf_hooks: invoke performance_entry_callback via MakeSyncCallback()
It's desirable to retain async_contexts active at callsites of
perf_hooks.performance.mark() and alike in the subsequent
PerformanceObserver invocations such that the latter can access e.g.
associated AsyncLocalStorage instances.
In working towards this goal replace the node::MakeCallback(...,
async_context{0, 0}) in PerformanceEntry::doNotify() by the new
node::MakeSyncCallback() introduced specifically for this purpose.
This change will retain the original async_context, if any, in
perf_hook's observersCallback() and thus, for the subsequent doNotify()
on unbuffered PerformanceObservers.
Co-Authored-By: ZauberNerd <zaubernerd@zaubernerd.de>
PR-URL: #36343
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 4f3d7bb commit e2ced0d
1 file changed
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -159,11 +159,10 @@ void PerformanceEntry::Notify(Environment* env, | |||
| 159 | 159 | AliasedUint32Array& observers = env->performance_state()->observers; | |
| 160 | 160 | if (!env->performance_entry_callback().IsEmpty() && | |
| 161 | 161 | type != NODE_PERFORMANCE_ENTRY_TYPE_INVALID && observers[type]) { | |
| 162 | - node::MakeCallback(env->isolate(), | ||
| 163 | - object.As<Object>(), | ||
| 164 | - env->performance_entry_callback(), | ||
| 165 | - 1, &object, | ||
| 166 | - node::async_context{0, 0}); | ||
| 162 | + node::MakeSyncCallback(env->isolate(), | ||
| 163 | + object.As<Object>(), | ||
| 164 | + env->performance_entry_callback(), | ||
| 165 | + 1, &object); | ||
| 167 | 166 | } | |
| 168 | 167 | } | |
| 169 | 168 | ||
0 commit comments