Commit e2df381
tools: add double-quotes to make-v8.sh
This is not being flagged in CI because (I'm guessing) shellcheck in CI
is 0.7.0 but latest is 0.8.0.
PR-URL: #41257
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent ab5e94c commit e2df381
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -17,7 +17,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then | |||
| 17 | 17 | fi | |
| 18 | 18 | # set paths manually for now to use locally installed gn | |
| 19 | 19 | export BUILD_TOOLS=/home/iojs/build-tools | |
| 20 | - export LD_LIBRARY_PATH=$BUILD_TOOLS:$LD_LIBRARY_PATH | ||
| 20 | + export LD_LIBRARY_PATH="$BUILD_TOOLS:$LD_LIBRARY_PATH" | ||
| 21 | 21 | # Avoid linking to ccache symbolic links as ccache decides which | |
| 22 | 22 | # binary to run based on the name of the link (we always name them gcc/g++). | |
| 23 | 23 | # shellcheck disable=SC2154 | |
@@ -28,7 +28,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then | |||
| 28 | 28 | rm -f "$BUILD_TOOLS/gcc" | |
| 29 | 29 | ln -s "$CXX_PATH" "$BUILD_TOOLS/g++" | |
| 30 | 30 | ln -s "$CC_PATH" "$BUILD_TOOLS/gcc" | |
| 31 | - export PATH=$BUILD_TOOLS:$PATH | ||
| 31 | + export PATH="$BUILD_TOOLS:$PATH" | ||
| 32 | 32 | ||
| 33 | 33 | g++ --version | |
| 34 | 34 | gcc --version | |
0 commit comments