Revert "deps: always define V8_EXPORT_PRIVATE as no-op" · nodejs/node@e3193ee · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e3193ee

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

Revert "deps: always define V8_EXPORT_PRIVATE as no-op"

This reverts commit ffadf35. PR-URL: #58187 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent e75ecf8 commit e3193ee
Copy full SHA for e3193ee

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi
• deps/v8/src/base
  • macros.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -38,7 +38,7 @@
38	38
39	39	# Reset this number to 0 on major V8 upgrades.
40	40	# Increment by one for each non-official patch applied to deps/v8.
41		- 'v8_embedder_string': '-node.11',
	41	+ 'v8_embedder_string': '-node.12',
42	42
43	43	##### V8 defaults for Node.js #####
44	44

Collapse file

‎deps/v8/src/base/macros.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/base/macros.h

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -442,9 +442,9 @@ bool is_inbounds(float_t v) {
442	442	// Setup for Windows shared library export.
443	443	#define V8_EXPORT_ENUM
444	444	#ifdef BUILDING_V8_SHARED_PRIVATE
445		- #define V8_EXPORT_PRIVATE
	445	+ #define V8_EXPORT_PRIVATE __declspec(dllexport)
446	446	#elif USING_V8_SHARED_PRIVATE
447		- #define V8_EXPORT_PRIVATE
	447	+ #define V8_EXPORT_PRIVATE __declspec(dllimport)
448	448	#else
449	449	#define V8_EXPORT_PRIVATE
450	450	#endif // BUILDING_V8_SHARED
@@ -454,7 +454,7 @@ bool is_inbounds(float_t v) {
454	454	// Setup for Linux shared library export.
455	455	#if V8_HAS_ATTRIBUTE_VISIBILITY && \
456	456	(defined(BUILDING_V8_SHARED_PRIVATE) || USING_V8_SHARED_PRIVATE)
457		- #define V8_EXPORT_PRIVATE
	457	+ #define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
458	458	#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE
459	459	#else
460	460	#define V8_EXPORT_PRIVATE

0 commit comments

Comments

0 (0)