Commit e384291
events: remove return value on addEventListener
The `addEventListener()` should not return a value.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37696
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 3e1a46a commit e384291
2 files changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -329,7 +329,7 @@ class EventTarget { | |||
| 329 | 329 | ||
| 330 | 330 | if (signal) { | |
| 331 | 331 | if (signal.aborted) { | |
| 332 | - return false; | ||
| 332 | + return; | ||
| 333 | 333 | } | |
| 334 | 334 | // TODO(benjamingr) make this weak somehow? ideally the signal would | |
| 335 | 335 | // not prevent the event target from GC. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -25,7 +25,11 @@ const { | |||
| 25 | 25 | controller.abort(); | |
| 26 | 26 | et.dispatchEvent(new Event('test')); | |
| 27 | 27 | strictEqual(count, 2, 'Aborting on the controller removes the listener'); | |
| 28 | - et.addEventListener('test', handler, { signal: controller.signal }); | ||
| 28 | + // See: https://github.com/nodejs/node/pull/37696 , adding an event listener | ||
| 29 | + // should always return undefined. | ||
| 30 | + strictEqual( | ||
| 31 | + et.addEventListener('test', handler, { signal: controller.signal }), | ||
| 32 | + undefined); | ||
| 29 | 33 | et.dispatchEvent(new Event('test')); | |
| 30 | 34 | strictEqual(count, 2, 'Passing an aborted signal never adds the handler'); | |
| 31 | 35 | } | |
0 commit comments