Commit e397d19
http2: remove unnecessary v8 qualified names
This commit removes v8 qualified identifiers that have using directives
to be consistent with the rest of the code in node_http2.cc.
PR-URL: #20420
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent b2bbc36 commit e397d19
1 file changed
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -110,7 +110,7 @@ Http2Options::Http2Options(Environment* env) { | |||
| 110 | 110 | // a bit differently. For now, let's let nghttp2 take care of it. | |
| 111 | 111 | nghttp2_option_set_builtin_recv_extension_type(options_, NGHTTP2_ALTSVC); | |
| 112 | 112 | ||
| 113 | - AliasedBuffer<uint32_t, v8::Uint32Array>& buffer = | ||
| 113 | + AliasedBuffer<uint32_t, Uint32Array>& buffer = | ||
| 114 | 114 | env->http2_state()->options_buffer; | |
| 115 | 115 | uint32_t flags = buffer[IDX_OPTIONS_FLAGS]; | |
| 116 | 116 | ||
@@ -191,7 +191,7 @@ Http2Options::Http2Options(Environment* env) { | |||
| 191 | 191 | } | |
| 192 | 192 | ||
| 193 | 193 | void Http2Session::Http2Settings::Init() { | |
| 194 | - AliasedBuffer<uint32_t, v8::Uint32Array>& buffer = | ||
| 194 | + AliasedBuffer<uint32_t, Uint32Array>& buffer = | ||
| 195 | 195 | env()->http2_state()->settings_buffer; | |
| 196 | 196 | uint32_t flags = buffer[IDX_SETTINGS_COUNT]; | |
| 197 | 197 | ||
@@ -270,7 +270,7 @@ Local<Value> Http2Session::Http2Settings::Pack() { | |||
| 270 | 270 | void Http2Session::Http2Settings::Update(Environment* env, | |
| 271 | 271 | Http2Session* session, | |
| 272 | 272 | get_setting fn) { | |
| 273 | - AliasedBuffer<uint32_t, v8::Uint32Array>& buffer = | ||
| 273 | + AliasedBuffer<uint32_t, Uint32Array>& buffer = | ||
| 274 | 274 | env->http2_state()->settings_buffer; | |
| 275 | 275 | buffer[IDX_SETTINGS_HEADER_TABLE_SIZE] = | |
| 276 | 276 | fn(**session, NGHTTP2_SETTINGS_HEADER_TABLE_SIZE); | |
@@ -288,7 +288,7 @@ void Http2Session::Http2Settings::Update(Environment* env, | |||
| 288 | 288 | ||
| 289 | 289 | // Initializes the shared TypedArray with the default settings values. | |
| 290 | 290 | void Http2Session::Http2Settings::RefreshDefaults(Environment* env) { | |
| 291 | - AliasedBuffer<uint32_t, v8::Uint32Array>& buffer = | ||
| 291 | + AliasedBuffer<uint32_t, Uint32Array>& buffer = | ||
| 292 | 292 | env->http2_state()->settings_buffer; | |
| 293 | 293 | ||
| 294 | 294 | buffer[IDX_SETTINGS_HEADER_TABLE_SIZE] = | |
@@ -505,7 +505,7 @@ Http2Session::~Http2Session() { | |||
| 505 | 505 | } | |
| 506 | 506 | ||
| 507 | 507 | inline bool HasHttp2Observer(Environment* env) { | |
| 508 | - AliasedBuffer<uint32_t, v8::Uint32Array>& observers = | ||
| 508 | + AliasedBuffer<uint32_t, Uint32Array>& observers = | ||
| 509 | 509 | env->performance_state()->observers; | |
| 510 | 510 | return observers[performance::NODE_PERFORMANCE_ENTRY_TYPE_HTTP2] != 0; | |
| 511 | 511 | } | |
@@ -522,7 +522,7 @@ void Http2Stream::EmitStatistics() { | |||
| 522 | 522 | if (!HasHttp2Observer(env)) | |
| 523 | 523 | return; | |
| 524 | 524 | HandleScope handle_scope(env->isolate()); | |
| 525 | - AliasedBuffer<double, v8::Float64Array>& buffer = | ||
| 525 | + AliasedBuffer<double, Float64Array>& buffer = | ||
| 526 | 526 | env->http2_state()->stream_stats_buffer; | |
| 527 | 527 | buffer[IDX_STREAM_STATS_ID] = entry->id(); | |
| 528 | 528 | if (entry->first_byte() != 0) { | |
@@ -561,7 +561,7 @@ void Http2Session::EmitStatistics() { | |||
| 561 | 561 | if (!HasHttp2Observer(env)) | |
| 562 | 562 | return; | |
| 563 | 563 | HandleScope handle_scope(env->isolate()); | |
| 564 | - AliasedBuffer<double, v8::Float64Array>& buffer = | ||
| 564 | + AliasedBuffer<double, Float64Array>& buffer = | ||
| 565 | 565 | env->http2_state()->session_stats_buffer; | |
| 566 | 566 | buffer[IDX_SESSION_STATS_TYPE] = entry->type(); | |
| 567 | 567 | buffer[IDX_SESSION_STATS_PINGRTT] = entry->ping_rtt() / 1e6; | |
@@ -690,7 +690,7 @@ ssize_t Http2Session::OnCallbackPadding(size_t frameLen, | |||
| 690 | 690 | Local<Context> context = env()->context(); | |
| 691 | 691 | Context::Scope context_scope(context); | |
| 692 | 692 | ||
| 693 | - AliasedBuffer<uint32_t, v8::Uint32Array>& buffer = | ||
| 693 | + AliasedBuffer<uint32_t, Uint32Array>& buffer = | ||
| 694 | 694 | env()->http2_state()->padding_buffer; | |
| 695 | 695 | buffer[PADDING_BUF_FRAME_LENGTH] = frameLen; | |
| 696 | 696 | buffer[PADDING_BUF_MAX_PAYLOAD_LENGTH] = maxPayloadLen; | |
@@ -2158,7 +2158,7 @@ void Http2Session::RefreshState(const FunctionCallbackInfo<Value>& args) { | |||
| 2158 | 2158 | ASSIGN_OR_RETURN_UNWRAP(&session, args.Holder()); | |
| 2159 | 2159 | DEBUG_HTTP2SESSION(session, "refreshing state"); | |
| 2160 | 2160 | ||
| 2161 | - AliasedBuffer<double, v8::Float64Array>& buffer = | ||
| 2161 | + AliasedBuffer<double, Float64Array>& buffer = | ||
| 2162 | 2162 | env->http2_state()->session_state_buffer; | |
| 2163 | 2163 | ||
| 2164 | 2164 | nghttp2_session* s = **session; | |
@@ -2448,7 +2448,7 @@ void Http2Stream::RefreshState(const FunctionCallbackInfo<Value>& args) { | |||
| 2448 | 2448 | ||
| 2449 | 2449 | DEBUG_HTTP2STREAM(stream, "refreshing state"); | |
| 2450 | 2450 | ||
| 2451 | - AliasedBuffer<double, v8::Float64Array>& buffer = | ||
| 2451 | + AliasedBuffer<double, Float64Array>& buffer = | ||
| 2452 | 2452 | env->http2_state()->stream_state_buffer; | |
| 2453 | 2453 | ||
| 2454 | 2454 | nghttp2_stream* str = **stream; | |
0 commit comments