Commit e3ad05d
deps: V8: cherry-pick 500de8bd371b
Original commit message:
[gcc] Fix gcc / bazel build
Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling
pointer warning introduced in newer gcc, since it has false positives
on some uses of scope classes.
Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#92977}
Refs: v8/v8@500de8b
PR-URL: #52676
Fixes: #52675
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>1 parent a501860 commit e3ad05d
4 files changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.22', | ||
| 40 | + 'v8_embedder_string': '-node.23', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1603,6 +1603,10 @@ config("toolchain") { | |||
| 1603 | 1603 | ||
| 1604 | 1604 | # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108517 | |
| 1605 | 1605 | "-Wno-nonnull", | |
| 1606 | + | ||
| 1607 | + # Disable dangling pointer warnings, which are often false positives when | ||
| 1608 | + # using scopes. | ||
| 1609 | + "-Wno-dangling-pointer", | ||
| 1606 | 1610 | ] | |
| 1607 | 1611 | } | |
| 1608 | 1612 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -6,6 +6,7 @@ | |||
| 6 | 6 | #define V8_COMPILER_TURBOSHAFT_ASSEMBLER_H_ | |
| 7 | 7 | ||
| 8 | 8 | #include <cstring> | |
| 9 | + #include <iomanip> | ||
| 9 | 10 | #include <iterator> | |
| 10 | 11 | #include <limits> | |
| 11 | 12 | #include <memory> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4,6 +4,8 @@ | |||
| 4 | 4 | ||
| 5 | 5 | #include "src/wasm/wasm-disassembler.h" | |
| 6 | 6 | ||
| 7 | + #include <iomanip> | ||
| 8 | + | ||
| 7 | 9 | #include "src/debug/debug-interface.h" | |
| 8 | 10 | #include "src/numbers/conversions.h" | |
| 9 | 11 | #include "src/wasm/module-decoder-impl.h" | |
0 commit comments