Commit e4d5e25
test: isolate rerun-failures state file under tmpdir
The rerun-failures state file lived at a fixed path under fixtures/,
so concurrent invocations of test-runner-test-rerun-failures (e.g.
`python tools/test.py --repeat 100 -j 16 ...`) raced on a single file
and failed intermittently. Move the path to `tmpdir.resolve(...)` so
each process gets its own scratch state.
Signed-off-by: atlowChemi <chemi@atlow.co.il>
PR-URL: #63449
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent dc57173 commit e4d5e25
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,5 +1,6 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | 2 | const common = require('../common'); | |
| 3 | + const tmpdir = require('../common/tmpdir'); | ||
| 3 | 4 | ||
| 4 | 5 | const fixtures = require('../common/fixtures'); | |
| 5 | 6 | const assert = require('node:assert'); | |
@@ -8,7 +9,8 @@ const { setTimeout } = require('node:timers/promises'); | |||
| 8 | 9 | const { test, beforeEach, afterEach, run } = require('node:test'); | |
| 9 | 10 | ||
| 10 | 11 | const fixture = fixtures.path('test-runner', 'rerun.js'); | |
| 11 | - const stateFile = fixtures.path('test-runner', 'rerun-state.json'); | ||
| 12 | + tmpdir.refresh(); | ||
| 13 | + const stateFile = tmpdir.resolve('rerun-state.json'); | ||
| 12 | 14 | ||
| 13 | 15 | beforeEach(() => rm(stateFile, { force: true })); | |
| 14 | 16 | afterEach(() => rm(stateFile, { force: true })); | |
0 commit comments