Commit e4e5137
errors: handle V8 warnings in DisallowJavascriptExecutionScope
Defer non-critical warnings to the next event loop iteration when
can_call_into_js() returns false. This prevents crashes when V8
emits warnings during REPL preview evaluation or other contexts
where JavaScript execution is temporarily forbidden.
When a warning is emitted inside DisallowJavascriptExecutionScope,
ProcessEmitWarningGeneric cannot be called immediately. Instead,
use env->SetImmediate() to queue the warning emission for after
the scope exits. This preserves full warning formatting, deprecation
codes, and --redirect-warnings routing.
Signed-off-by: Divyanshu Sharma <Divyanshu88999@gmail.com>
PR-URL: #63491
Fixes: #63473
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent d3ef412 commit e4e5137
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1064,7 +1064,12 @@ void PerIsolateMessageListener(Local<Message> message, Local<Value> error) { | |||
| 1064 | 1064 | filename, | |
| 1065 | 1065 | message->GetLineNumber(env->context()).FromMaybe(-1), | |
| 1066 | 1066 | msg); | |
| 1067 | - USE(ProcessEmitWarningGeneric(env, warning, "V8")); | ||
| 1067 | + // Defer the warning to the next event loop iteration. This prevents | ||
| 1068 | + // crashes when V8 emits warnings during code evaluation with | ||
| 1069 | + // throwOnSideEffect. | ||
| 1070 | + env->SetImmediate([warning](Environment* env) { | ||
| 1071 | + ProcessEmitWarningGeneric(env, warning, "V8"); | ||
| 1072 | + }); | ||
| 1068 | 1073 | break; | |
| 1069 | 1074 | } | |
| 1070 | 1075 | case Isolate::MessageErrorLevel::kMessageError: | |
0 commit comments