Commit e53506a
test: update test-tls-check-server-identity.js
Changed var to const, assert.equal to assert.strictEqual, and
used a template string for error output.
PR-URL: #9986
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent bdf633a commit e53506a
1 file changed
Lines changed: 11 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,16 +1,17 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - var common = require('../common'); | ||
| 3 | - var assert = require('assert'); | ||
| 4 | - var util = require('util'); | ||
| 2 | + const common = require('../common'); | ||
| 5 | 3 | ||
| 6 | 4 | if (!common.hasCrypto) { | |
| 7 | 5 | common.skip('missing crypto'); | |
| 8 | 6 | return; | |
| 9 | 7 | } | |
| 10 | - var tls = require('tls'); | ||
| 11 | 8 | ||
| 9 | + const assert = require('assert'); | ||
| 10 | + const util = require('util'); | ||
| 12 | 11 | ||
| 13 | - var tests = [ | ||
| 12 | + const tls = require('tls'); | ||
| 13 | + | ||
| 14 | + const tests = [ | ||
| 14 | 15 | // False-y values. | |
| 15 | 16 | { | |
| 16 | 17 | host: false, | |
@@ -253,9 +254,9 @@ var tests = [ | |||
| 253 | 254 | ]; | |
| 254 | 255 | ||
| 255 | 256 | tests.forEach(function(test, i) { | |
| 256 | - var err = tls.checkServerIdentity(test.host, test.cert); | ||
| 257 | - assert.equal(err && err.reason, | ||
| 258 | - test.error, | ||
| 259 | - 'Test#' + i + ' failed: ' + util.inspect(test) + '\n' + | ||
| 260 | - test.error + ' != ' + (err && err.reason)); | ||
| 257 | + const err = tls.checkServerIdentity(test.host, test.cert); | ||
| 258 | + assert.strictEqual(err && err.reason, | ||
| 259 | + test.error, | ||
| 260 | + `Test# ${i} failed: ${util.inspect(test)} \n` + | ||
| 261 | + `${test.error} != ${(err && err.reason)}`); | ||
| 261 | 262 | }); | |
0 commit comments