lib: replace ArrayBuffer.isView by primordial ArrayBuffer · nodejs/node@e53f5af · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e53f5af

Browse filesBrowse the repository at this point in the historyBrowse files

Kawacrepe

authored and

BethGriggs

committed

lib: replace ArrayBuffer.isView by primordial ArrayBuffer

PR-URL: #30692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

1 parent 9260844 commit e53f5af
Copy full SHA for e53f5af

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • string_decoder.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/string_decoder.js‎

Copy file name to clipboardExpand all lines: lib/string_decoder.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -22,6 +22,7 @@
22	22	'use strict';
23	23
24	24	const {
	25	+ ArrayBufferIsView,
25	26	ObjectDefineProperties,
26	27	} = primordials;
27	28
@@ -74,7 +75,7 @@ function StringDecoder(encoding) {
74	75	StringDecoder.prototype.write = function write(buf) {
75	76	if (typeof buf === 'string')
76	77	return buf;
77		- if (!ArrayBuffer.isView(buf))
	78	+ if (!ArrayBufferIsView(buf))
78	79	throw new ERR_INVALID_ARG_TYPE('buf',
79	80	['Buffer', 'TypedArray', 'DataView'],
80	81	buf);

0 commit comments

Comments

0 (0)