Commit e54f75b
readline: remove the caching variable
Line 486 and 525 contain for loops where a length property is cached in
a variable (for example, itemLen). This used to be a performance
optimization, but current V8 handles the optimization internally.
These caching variables are removed, and the length property is used
directly instead.
PR-URL: #14275
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>1 parent e237720 commit e54f75b
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -472,7 +472,7 @@ Interface.prototype._tabComplete = function(lastKeypressWasTab) { | |||
| 472 | 472 | maxColumns = 1; | |
| 473 | 473 | } | |
| 474 | 474 | var group = []; | |
| 475 | - for (var i = 0, compLen = completions.length; i < compLen; i++) { | ||
| 475 | + for (var i = 0; i < completions.length; i++) { | ||
| 476 | 476 | var c = completions[i]; | |
| 477 | 477 | if (c === '') { | |
| 478 | 478 | handleGroup(self, group, width, maxColumns); | |
@@ -511,7 +511,7 @@ function handleGroup(self, group, width, maxColumns) { | |||
| 511 | 511 | var item = group[idx]; | |
| 512 | 512 | self._writeToOutput(item); | |
| 513 | 513 | if (col < maxColumns - 1) { | |
| 514 | - for (var s = 0, itemLen = item.length; s < width - itemLen; s++) { | ||
| 514 | + for (var s = 0; s < width - item.length; s++) { | ||
| 515 | 515 | self._writeToOutput(' '); | |
| 516 | 516 | } | |
| 517 | 517 | } | |
0 commit comments