test: verify the shell option works properly on execFile · nodejs/node@e55e08c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e55e08c

Browse filesBrowse the repository at this point in the historyBrowse files

jvelezpo

authored and

MylesBorins

committed

test: verify the shell option works properly on execFile

Useful for executing in a shell because it accepts arguments as an array instead of a string as exec does. Depending on the circumstances, that can prove to be useful if the arguments are already prepared. PR-URL: #18384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent 0cf9d04 commit e55e08c
Copy full SHA for e55e08c

2 files changed

+14Lines changed: 14 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • parallel
    • test-child-process-execfile.js
  • sequential
    • test-child-process-execsync.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-child-process-execfile.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-execfile.js

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -6,6 +6,7 @@ const uv = process.binding('uv');
6	6	const fixtures = require('../common/fixtures');
7	7
8	8	const fixture = fixtures.path('exit.js');
	9	+ const execOpts = { encoding: 'utf8', shell: true };
9	10
10	11	{
11	12	execFile(
@@ -38,3 +39,10 @@ const fixture = fixtures.path('exit.js');
38	39	child.kill();
39	40	child.emit('close', code, null);
40	41	}
	42	+
	43	+ {
	44	+ // Verify the shell option works properly
	45	+ execFile(process.execPath, [fixture, 0], execOpts, common.mustCall((err) => {
	46	+ assert.ifError(err);
	47	+ }));
	48	+ }

Collapse file

‎test/sequential/test-child-process-execsync.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-child-process-execsync.js

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -29,6 +29,7 @@ const TIMER = 200;
29	29	const SLEEP = 2000;
30	30
31	31	const start = Date.now();
	32	+ const execOpts = { encoding: 'utf8', shell: true };
32	33	let err;
33	34	let caught = false;
34	35
@@ -124,3 +125,8 @@ assert.strictEqual(ret, `${msg}\n`);
124	125	return true;
125	126	});
126	127	}
	128	+
	129	+ // Verify the shell option works properly
	130	+ assert.doesNotThrow(() => {
	131	+ execFileSync(process.execPath, [], execOpts);
	132	+ });

0 commit comments

Comments

0 (0)