Commit e561585
contextify: use CHECK instead of if
I was walking through the vm changes and saw this particular `if` check
interesting. In case `ctx` is empty it's going to fail later anyways.
So, instead of putting an `if` check there;
option a - use CHECK
option b - do nothing
Considering the developer wanted to make sure `ctx` is not empty,
`CHECK` option looked more convenient.
PR-URL: #3125
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>1 parent 4c59407 commit e561585
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -216,8 +216,9 @@ class ContextifyContext { | |||
| 216 | 216 | object_template->SetHandler(config); | |
| 217 | 217 | ||
| 218 | 218 | Local<Context> ctx = Context::New(env->isolate(), nullptr, object_template); | |
| 219 | - if (!ctx.IsEmpty()) | ||
| 220 | - ctx->SetSecurityToken(env->context()->GetSecurityToken()); | ||
| 219 | + | ||
| 220 | + CHECK(!ctx.IsEmpty()); | ||
| 221 | + ctx->SetSecurityToken(env->context()->GetSecurityToken()); | ||
| 221 | 222 | ||
| 222 | 223 | env->AssignToContext(ctx); | |
| 223 | 224 | ||
0 commit comments