fs: only use Buffer.concat in promises.readFile when necessary · nodejs/node@e582832 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e582832

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

targos

committed

fs: only use Buffer.concat in promises.readFile when necessary

PR-URL: #37127 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 6264ac1 commit e582832
Copy full SHA for e582832

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/fs
  • promises.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -311,7 +311,7 @@ async function readFileHandle(filehandle, options) {
311	311	chunks.push(buffer.slice(0, bytesRead));
312	312	} while (!endOfFile);
313	313
314		- const result = Buffer.concat(chunks);
	314	+ const result = chunks.length === 1 ? chunks[0] : Buffer.concat(chunks);
315	315
316	316	return options.encoding ? result.toString(options.encoding) : result;
317	317	}

0 commit comments

Comments

0 (0)