Commit e58f14f
inspector: drop 'chrome-' from inspector url
It has been reported that the
https://github.com/cjihrig/node-v8-inspector V8 inspector
extension can no longer connect DevTools (despite no code changes
to the extension since Feb. 2017). Upon investigation, Chrome
dropped support for the chrome-devtools: scheme recently. I've
confirmed that dropping 'chrome-' from the URL here allows the
debugger to function properly with modern Chrome.
Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779
PR-URL: #33758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>1 parent b10d203 commit e58f14f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -373,7 +373,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket, | |||
| 373 | 373 | std::string InspectorSocketServer::GetFrontendURL(bool is_compat, | |
| 374 | 374 | const std::string &formatted_address) { | |
| 375 | 375 | std::ostringstream frontend_url; | |
| 376 | - frontend_url << "chrome-devtools://devtools/bundled/"; | ||
| 376 | + frontend_url << "devtools://devtools/bundled/"; | ||
| 377 | 377 | frontend_url << (is_compat ? "inspector" : "js_app"); | |
| 378 | 378 | frontend_url << ".html?experiments=true&v8only=true&ws="; | |
| 379 | 379 | frontend_url << formatted_address; | |
0 commit comments