Commit e5de225
test: simplify assertion in http2 tests
In test-http2-timeout-large-write.js and
test-http2-timeout-large-write-file.js:
Use assert.ok() on a boolean that the test itself creates and sets,
rather than assert.strictEqual(). This allows us to use a static message
without running afoul of the upcoming "do not use string literals with
assert.strictEqual()" lint rule.
Backport-PR-URL: #22912
PR-URL: #22849
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent b31a4d0 commit e5de225
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -48,7 +48,7 @@ server.on('stream', common.mustCall((stream) => { | |||
| 48 | 48 | })); | |
| 49 | 49 | server.setTimeout(serverTimeout); | |
| 50 | 50 | server.on('timeout', () => { | |
| 51 | - assert.strictEqual(didReceiveData, false, 'Should not timeout'); | ||
| 51 | + assert.ok(!didReceiveData, 'Should not timeout'); | ||
| 52 | 52 | }); | |
| 53 | 53 | ||
| 54 | 54 | server.listen(0, common.mustCall(() => { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -40,13 +40,13 @@ server.on('stream', common.mustCall((stream) => { | |||
| 40 | 40 | stream.write(content); | |
| 41 | 41 | stream.setTimeout(serverTimeout); | |
| 42 | 42 | stream.on('timeout', () => { | |
| 43 | - assert.strictEqual(didReceiveData, false, 'Should not timeout'); | ||
| 43 | + assert.ok(!didReceiveData, 'Should not timeout'); | ||
| 44 | 44 | }); | |
| 45 | 45 | stream.end(); | |
| 46 | 46 | })); | |
| 47 | 47 | server.setTimeout(serverTimeout); | |
| 48 | 48 | server.on('timeout', () => { | |
| 49 | - assert.strictEqual(didReceiveData, false, 'Should not timeout'); | ||
| 49 | + assert.ok(!didReceiveData, 'Should not timeout'); | ||
| 50 | 50 | }); | |
| 51 | 51 | ||
| 52 | 52 | server.listen(0, common.mustCall(() => { | |
0 commit comments