Commit e600de9
committed
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.
Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent cc36db7 commit e600de9
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.1', | ||
| 39 | + 'v8_embedder_string': '-node.2', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1021,7 +1021,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code") | |||
| 1021 | 1021 | DEFINE_BOOL_READONLY(concurrent_sparkplug, false, | |
| 1022 | 1022 | "compile Sparkplug code in a background thread") | |
| 1023 | 1023 | #else | |
| 1024 | - DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT, | ||
| 1024 | + DEFINE_BOOL(concurrent_sparkplug, false, | ||
| 1025 | 1025 | "compile Sparkplug code in a background thread") | |
| 1026 | 1026 | DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug) | |
| 1027 | 1027 | DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug) | |
0 commit comments