Commit e72761a
src: return references from getters, not copies
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent aded597 commit e72761a
1 file changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -70,11 +70,11 @@ class PerformanceEntry : public BaseObject { | |||
| 70 | 70 | return env_; | |
| 71 | 71 | } | |
| 72 | 72 | ||
| 73 | - std::string name() const { | ||
| 73 | + const std::string& name() const { | ||
| 74 | 74 | return name_; | |
| 75 | 75 | } | |
| 76 | 76 | ||
| 77 | - std::string type() const { | ||
| 77 | + const std::string& type() const { | ||
| 78 | 78 | return type_; | |
| 79 | 79 | } | |
| 80 | 80 | ||
@@ -132,11 +132,11 @@ class PerformanceEntry : public BaseObject { | |||
| 132 | 132 | ||
| 133 | 133 | ~PerformanceEntry() {} | |
| 134 | 134 | ||
| 135 | - std::string name() const { | ||
| 135 | + const std::string& name() const { | ||
| 136 | 136 | return name_; | |
| 137 | 137 | } | |
| 138 | 138 | ||
| 139 | - std::string type() const { | ||
| 139 | + const std::string& type() const { | ||
| 140 | 140 | return type_; | |
| 141 | 141 | } | |
| 142 | 142 | ||
0 commit comments