Commit e79351c
test: improve test-https-agent.js
On line 40: replace '==' with '==='
On line 52: replace 'assert.equal' with 'assert.strictEqual'
Added some comments.
Changed 'var' to 'const' where possible.
Replaced console.log(res.statusCode); with and assertion.
Rather than logging the https request status on every loop it will now
assert the https status is correct on every loop.
Changed the error listener to throw the error rather than log it.
PR-URL: #8517
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 9ffb2f3 commit e79351c
1 file changed
Lines changed: 13 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,30 +1,31 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - var common = require('../common'); | ||
| 3 | - var assert = require('assert'); | ||
| 2 | + const common = require('../common'); | ||
| 3 | + const assert = require('assert'); | ||
| 4 | 4 | ||
| 5 | 5 | if (!common.hasCrypto) { | |
| 6 | 6 | common.skip('missing crypto'); | |
| 7 | 7 | return; | |
| 8 | 8 | } | |
| 9 | - var https = require('https'); | ||
| 9 | + const https = require('https'); | ||
| 10 | 10 | ||
| 11 | - var fs = require('fs'); | ||
| 11 | + const fs = require('fs'); | ||
| 12 | 12 | ||
| 13 | - var options = { | ||
| 13 | + const options = { | ||
| 14 | 14 | key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'), | |
| 15 | 15 | cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem') | |
| 16 | 16 | }; | |
| 17 | 17 | ||
| 18 | 18 | ||
| 19 | - var server = https.Server(options, function(req, res) { | ||
| 19 | + const server = https.Server(options, function(req, res) { | ||
| 20 | 20 | res.writeHead(200); | |
| 21 | 21 | res.end('hello world\n'); | |
| 22 | 22 | }); | |
| 23 | 23 | ||
| 24 | 24 | ||
| 25 | 25 | var responses = 0; | |
| 26 | - var N = 4; | ||
| 27 | - var M = 4; | ||
| 26 | + const N = 4; | ||
| 27 | + const M = 4; | ||
| 28 | + | ||
| 28 | 29 | ||
| 29 | 30 | server.listen(0, function() { | |
| 30 | 31 | for (var i = 0; i < N; i++) { | |
@@ -36,11 +37,10 @@ server.listen(0, function() { | |||
| 36 | 37 | rejectUnauthorized: false | |
| 37 | 38 | }, function(res) { | |
| 38 | 39 | res.resume(); | |
| 39 | - console.log(res.statusCode); | ||
| 40 | - if (++responses == N * M) server.close(); | ||
| 40 | + assert.strictEqual(res.statusCode, 200); | ||
| 41 | + if (++responses === N * M) server.close(); | ||
| 41 | 42 | }).on('error', function(e) { | |
| 42 | - console.log(e.message); | ||
| 43 | - process.exit(1); | ||
| 43 | + throw e; | ||
| 44 | 44 | }); | |
| 45 | 45 | } | |
| 46 | 46 | }, i); | |
@@ -49,5 +49,5 @@ server.listen(0, function() { | |||
| 49 | 49 | ||
| 50 | 50 | ||
| 51 | 51 | process.on('exit', function() { | |
| 52 | - assert.equal(N * M, responses); | ||
| 52 | + assert.strictEqual(N * M, responses); | ||
| 53 | 53 | }); | |
0 commit comments