test: invalid package.json causes error when require()ing in directory · nodejs/node@e7c4dfb · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 761
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e7c4dfb

Browse filesBrowse the repository at this point in the historyBrowse files

Sam Shull

authored and

MylesBorins

committed

test: invalid package.json causes error when require()ing in directory

Requiring a file from a directory that contains an invalid package.json file should throw an error. PR-URL: #10044 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 22226fa commit e7c4dfb
Copy full SHA for e7c4dfb

3 files changed

+9Lines changed: 9 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • fixtures/packages/invalid
    • index.js
    • package.json
  • sequential
    • test-module-loading.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/fixtures/packages/invalid/index.js‎

Copy file name to clipboard

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1 @@
	1	+ exports.ok = 'ok';

Collapse file

‎test/fixtures/packages/invalid/package.json‎

Copy file name to clipboard

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1 @@
	1	+ {,}

Collapse file

‎test/sequential/test-module-loading.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-module-loading.js

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -69,6 +69,13 @@ assert.strictEqual(threeFolder, threeIndex);
69	69	assert.notStrictEqual(threeFolder, three);
70	70
71	71	console.error('test package.json require() loading');
	72	+ assert.throws(
	73	+ function() {
	74	+ require('../fixtures/packages/invalid');
	75	+ },
	76	+ /^SyntaxError: Error parsing \S+: Unexpected token ,$/
	77	+ );
	78	+
72	79	assert.strictEqual(require('../fixtures/packages/main').ok, 'ok',
73	80	'Failed loading package');
74	81	assert.strictEqual(require('../fixtures/packages/main-index').ok, 'ok',

0 commit comments

Comments

0 (0)