FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: expose libplatform symbols in shared libnode · nodejs/node@e80127f · GitHub

/ node Public

Commit e80127f

Browse files
joyeecheung
authored and
RafaelGSS
committed
build: expose libplatform symbols in shared libnode
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the public symbols since we build with hidden visibility by default. PR-URL: #61144 Fixes: #61102 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1 parent d998050 commit e80127f

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

‎node.gypi‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,11 @@
5050
'defines': [
5151
'USING_UV_SHARED',
5252
'USING_V8_SHARED',
53+
'USING_V8_PLATFORM_SHARED',
5354
'BUILDING_NODE_EXTENSION'
5455
],
5556
'defines!': [
57+
'BUILDING_V8_PLATFORM_SHARED=1',
5658
'BUILDING_V8_SHARED=1',
5759
'BUILDING_UV_SHARED=1'
5860
]

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
['OS!="aix" and OS!="os400"', {
5959
'defines': [
6060
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
61+
'BUILDING_V8_PLATFORM_SHARED', # Make V8_PLATFORM_EXPORT visible.
6162
]
6263
}],
6364
['node_shared=="true"', {
@@ -1345,6 +1346,7 @@
13451346
['component=="shared_library"', {
13461347
'defines': [
13471348
'BUILDING_V8_SHARED',
1349+
'BUILDING_V8_PLATFORM_SHARED',
13481350
],
13491351
}],
13501352
['v8_enable_i18n_support==1', {
@@ -1414,6 +1416,7 @@
14141416
'defines!': [
14151417
'_HAS_EXCEPTIONS=0',
14161418
'BUILDING_V8_SHARED=1',
1419+
'BUILDING_V8_PLATFORM_SHARED=1',
14171420
],
14181421
'cflags_cc!': ['-fno-exceptions'],
14191422
'cflags_cc': ['-fexceptions'],
@@ -1440,6 +1443,7 @@
14401443
'defines!': [
14411444
'_HAS_EXCEPTIONS=0',
14421445
'BUILDING_V8_SHARED=1',
1446+
'BUILDING_V8_PLATFORM_SHARED=1',
14431447
],
14441448
'cflags_cc!': ['-fno-exceptions'],
14451449
'cflags_cc': ['-fexceptions'],
@@ -1781,6 +1785,7 @@
17811785
],
17821786
'defines!': [
17831787
'BUILDING_V8_SHARED=1',
1788+
'BUILDING_V8_PLATFORM_SHARED=1',
17841789
],
17851790
'dependencies': [
17861791
'v8_libbase',
@@ -1862,6 +1867,7 @@
18621867
'defines!': [
18631868
'_HAS_EXCEPTIONS=0',
18641869
'BUILDING_V8_SHARED=1',
1870+
'BUILDING_V8_PLATFORM_SHARED=1',
18651871
],
18661872
'cflags_cc!': ['-fno-exceptions'],
18671873
'cflags_cc': ['-fexceptions'],
@@ -1905,6 +1911,7 @@
19051911
'defines!': [
19061912
'_HAS_EXCEPTIONS=0',
19071913
'BUILDING_V8_SHARED=1',
1914+
'BUILDING_V8_PLATFORM_SHARED=1',
19081915
],
19091916
'msvs_settings': {
19101917
'VCCLCompilerTool': {
@@ -2119,10 +2126,12 @@
21192126
],
21202127
'defines': [
21212128
'BUILDING_V8_SHARED',
2129+
'BUILDING_V8_PLATFORM_SHARED',
21222130
],
21232131
'direct_dependent_settings': {
21242132
'defines': [
21252133
'USING_V8_SHARED',
2134+
'USING_V8_PLATFORM_SHARED',
21262135
],
21272136
},
21282137
'conditions': [

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL