Commit e8538c3
build: fix node build failures in WSL Ubuntu
On WSL systems, `./configure` causes appending of carriage return
(`\r\r`) as leftover and will be appended to the `gyp_args`.
Therefore, it will lead to unhandled exceptions from the `./configure`
execution.
Excluded the empty or whitespace item from the `args` array to
fix the issue.
Fixes: #41459
PR-URL: #41476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent f5b8aee commit e8538c3
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2030,8 +2030,8 @@ def make_bin_override(): | |||
| 2030 | 2030 | if bin_override is not None: | |
| 2031 | 2031 | gyp_args += ['-Dpython=' + sys.executable] | |
| 2032 | 2032 | ||
| 2033 | - # pass the leftover positional arguments to GYP | ||
| 2034 | - gyp_args += args | ||
| 2033 | + # pass the leftover non-whitespace positional arguments to GYP | ||
| 2034 | + gyp_args += [arg for arg in args if not str.isspace(arg)] | ||
| 2035 | 2035 | ||
| 2036 | 2036 | if warn.warned and not options.verbose: | |
| 2037 | 2037 | warn('warnings were emitted in the configure phase') | |
0 commit comments