build: do not build with code cache for core coverage collection · nodejs/node@e862eec · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e862eec

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

build: do not build with code cache for core coverage collection

Disable code cache for built-ins when are building Node.js to collect test coverage of built-ins, as code caching makes the V8 coverage collection less precises (specifically, all the functions deserialized from the code cache will not have block-level coverage data). Data from local testing: Before: ---------|----------|---------|--------- % Stmts | % Branch | % Funcs | % Lines ---------|----------|---------|--------- 95.58 | 94.43 | 95.19 | 95.58 ---------|----------|---------|--------- After: ---------|----------|---------|--------- % Stmts | % Branch | % Funcs | % Lines ---------|----------|---------|--------- 95.93 | 94.77 | 96.03 | 95.93 ---------|----------|---------|--------- PR-URL: #54633 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>

1 parent f5c65d0 commit e862eec
Copy full SHA for e862eec

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• configure.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1389,7 +1389,9 @@ def configure_node(o):
1389	1389	o['variables']['node_use_node_snapshot'] = b(
1390	1390	not cross_compiling and not options.shared)
1391	1391
1392		- if options.without_node_code_cache or options.without_node_snapshot or options.node_builtin_modules_path:
	1392	+ # Do not use code cache when Node.js is built for collecting coverage of itself, this allows more
	1393	+ # precise coverage for the JS built-ins.
	1394	+ if options.without_node_code_cache or options.without_node_snapshot or options.node_builtin_modules_path or options.coverage:
1393	1395	o['variables']['node_use_node_code_cache'] = 'false'
1394	1396	else:
1395	1397	# TODO(refack): fix this when implementing embedded code-cache when cross-compiling.

0 commit comments

Comments

0 (0)