Commit e88a301
committed
tools: do not pass invalid flag to C compiler
`-Wno-invalid-offsetof` is only valid for C++ and GCC warns about its
usage for C.
PR-URL: #51409
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>1 parent ec60639 commit e88a301
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1989,6 +1989,12 @@ | |||
| 1989 | 1989 | ] | |
| 1990 | 1990 | }], | |
| 1991 | 1991 | ], | |
| 1992 | + # -Wno-invalid-offsetof flag is not valid for C. | ||
| 1993 | + # The flag is initially set in `toolchain.gypi` for all targets. | ||
| 1994 | + 'cflags!': [ '-Wno-invalid-offsetof' ], | ||
| 1995 | + 'xcode_settings': { | ||
| 1996 | + 'WARNING_CFLAGS!': ['-Wno-invalid-offsetof'] | ||
| 1997 | + }, | ||
| 1992 | 1998 | 'direct_dependent_settings': { | |
| 1993 | 1999 | 'include_dirs': [ | |
| 1994 | 2000 | '<(V8_ROOT)/third_party/zlib', | |
0 commit comments