Commit e8a6cc8
worker: improve JS-side debugging
Do not print debug messages that indicate that a stdio stream
has drained; because `util.debuglog()` uses `console.log`, which
in turn uses stdio streams, this would otherwise have lead to an
endless loop.
PR-URL: #25312
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent c6adf4b commit e8a6cc8
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -62,7 +62,8 @@ MessagePort.prototype.unref = MessagePortPrototype.unref; | |||
| 62 | 62 | // .onmessage events, and a function used for sending data to a MessagePort | |
| 63 | 63 | // in some other thread. | |
| 64 | 64 | MessagePort.prototype[kOnMessageListener] = function onmessage(payload) { | |
| 65 | - debug(`[${threadId}] received message`, payload); | ||
| 65 | + if (payload.type !== messageTypes.STDIO_WANTS_MORE_DATA) | ||
| 66 | + debug(`[${threadId}] received message`, payload); | ||
| 66 | 67 | // Emit the deserialized object to userland. | |
| 67 | 68 | this.emit('message', payload); | |
| 68 | 69 | }; | |
0 commit comments