src: use "constants" string instead of creating new one · nodejs/node@e8dbd09 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e8dbd09

Browse filesBrowse the repository at this point in the historyBrowse files

oyyd

authored and

rvagg

committed

src: use "constants" string instead of creating new one

Using the same "constants" string in c++. PR-URL: #23894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

1 parent fa12532 commit e8dbd09
Copy full SHA for e8dbd09

3 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_http2.cc
  • pipe_wrap.cc
  • tcp_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_http2.cc‎

Copy file name to clipboardExpand all lines: src/node_http2.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -3289,7 +3289,7 @@ HTTP_STATUS_CODES(V)
3289	3289	env->SetMethod(target, "packSettings", PackSettings);
3290	3290
3291	3291	target->Set(context,
3292		- FIXED_ONE_BYTE_STRING(isolate, "constants"),
	3292	+ env->constants_string(),
3293	3293	constants).FromJust();
3294	3294	target->Set(context,
3295	3295	FIXED_ONE_BYTE_STRING(isolate, "nameForErrorCode"),

Collapse file

‎src/pipe_wrap.cc‎

Copy file name to clipboardExpand all lines: src/pipe_wrap.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -117,7 +117,7 @@ void PipeWrap::Initialize(Local<Object> target,
117	117	NODE_DEFINE_CONSTANT(constants, SERVER);
118	118	NODE_DEFINE_CONSTANT(constants, IPC);
119	119	target->Set(context,
120		- FIXED_ONE_BYTE_STRING(env->isolate(), "constants"),
	120	+ env->constants_string(),
121	121	constants).FromJust();
122	122	}
123	123

Collapse file

‎src/tcp_wrap.cc‎

Copy file name to clipboardExpand all lines: src/tcp_wrap.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -132,7 +132,7 @@ void TCPWrap::Initialize(Local<Object> target,
132	132	NODE_DEFINE_CONSTANT(constants, SOCKET);
133	133	NODE_DEFINE_CONSTANT(constants, SERVER);
134	134	target->Set(context,
135		- FIXED_ONE_BYTE_STRING(env->isolate(), "constants"),
	135	+ env->constants_string(),
136	136	constants).FromJust();
137	137	}
138	138

0 commit comments

Comments

0 (0)