test: convert assertion that always fails to assert.fail() · nodejs/node@e8eed5c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e8eed5c

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

BethGriggs

committed

test: convert assertion that always fails to assert.fail()

In test-http-destroyed-socket-write2, the assert.strictEqual() in the default case of the switch statement will always fail because it checks for a value that is already accounted for in one of the switch cases. Convert it to assert.fail(). PR-URL: #34793 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 7d0970c commit e8eed5c
Copy full SHA for e8eed5c

1 file changed

+1-3Lines changed: 1 addition & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-destroyed-socket-write2.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-destroyed-socket-write2.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-destroyed-socket-write2.js

+1-3Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -64,9 +64,7 @@ server.listen(0, function() {
64	64
65	65	default:
66	66	// Write to a torn down client should RESET or ABORT
67		- assert.strictEqual(er.code,
68		- 'ECONNRESET');
69		- break;
	67	+ assert.fail(`Unexpected error code ${er.code}`);
70	68	}
71	69
72	70

0 commit comments

Comments

0 (0)