Commit e93b024
src: remove no longer relevant comments
PR-URL: #4843
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>1 parent 9dd5b3e commit e93b024
3 files changed
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -285,7 +285,6 @@ void Agent::ChildSignalCb(uv_async_t* signal) { | |||
| 285 | 285 | } | |
| 286 | 286 | ||
| 287 | 287 | // Waiting for client, do not send anything just yet | |
| 288 | - // TODO(indutny): move this to js-land | ||
| 289 | 288 | if (a->wait_) { | |
| 290 | 289 | a->messages_.PushFront(msg); // Push message back into the ready queue. | |
| 291 | 290 | break; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -109,7 +109,6 @@ class Agent { | |||
| 109 | 109 | kRunning | |
| 110 | 110 | }; | |
| 111 | 111 | ||
| 112 | - // TODO(indutny): Verify that there are no races | ||
| 113 | 112 | State state_; | |
| 114 | 113 | ||
| 115 | 114 | int port_; | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5177,7 +5177,7 @@ void PBKDF2(const FunctionCallbackInfo<Value>& args) { | |||
| 5177 | 5177 | ||
| 5178 | 5178 | if (args[5]->IsFunction()) { | |
| 5179 | 5179 | obj->Set(env->ondone_string(), args[5]); | |
| 5180 | - // XXX(trevnorris): This will need to go with the rest of domains. | ||
| 5180 | + | ||
| 5181 | 5181 | if (env->in_domain()) | |
| 5182 | 5182 | obj->Set(env->domain_string(), env->domain_array()->Get(0)); | |
| 5183 | 5183 | uv_queue_work(env->event_loop(), | |
@@ -5338,7 +5338,7 @@ void RandomBytes(const FunctionCallbackInfo<Value>& args) { | |||
| 5338 | 5338 | ||
| 5339 | 5339 | if (args[1]->IsFunction()) { | |
| 5340 | 5340 | obj->Set(FIXED_ONE_BYTE_STRING(args.GetIsolate(), "ondone"), args[1]); | |
| 5341 | - // XXX(trevnorris): This will need to go with the rest of domains. | ||
| 5341 | + | ||
| 5342 | 5342 | if (env->in_domain()) | |
| 5343 | 5343 | obj->Set(env->domain_string(), env->domain_array()->Get(0)); | |
| 5344 | 5344 | uv_queue_work(env->event_loop(), | |
0 commit comments