Commit e945bd9
committed
src: update NODE_MODULE_VERSION to 129
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.8.
Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent 1dfa3b8 commit e945bd9
2 files changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,8 @@ | |||
| 1 | 1 | { | |
| 2 | 2 | "NODE_MODULE_VERSION": [ | |
| 3 | - { "modules": 128, "runtime":"electron", "variant": "electron", "versions": "32" }, | ||
| 4 | - { "modules": 127, "runtime":"node", "variant": "v8_12.4", "versions": "22.0.0" }, | ||
| 3 | + { "modules": 129,"runtime": "node", "variant": "v8_12.8", "versions": "23.0.0-pre" }, | ||
| 4 | + { "modules": 128,"runtime": "electron", "variant": "electron", "versions": "32" }, | ||
| 5 | + { "modules": 127,"runtime": "node", "variant": "v8_12.4", "versions": "22.0.0" }, | ||
| 5 | 6 | { "modules": 126,"runtime": "node", "variant": "v8_12.3", "versions": "22.0.0-pre" }, | |
| 6 | 7 | { "modules": 125,"runtime": "electron", "variant": "electron", "versions": "31" }, | |
| 7 | 8 | { "modules": 124,"runtime": "node", "variant": "v8_12.2", "versions": "22.0.0-pre" }, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -95,7 +95,7 @@ | |||
| 95 | 95 | #if defined(NODE_EMBEDDER_MODULE_VERSION) | |
| 96 | 96 | #define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION | |
| 97 | 97 | #else | |
| 98 | - #define NODE_MODULE_VERSION 127 | ||
| 98 | + #define NODE_MODULE_VERSION 129 | ||
| 99 | 99 | #endif | |
| 100 | 100 | ||
| 101 | 101 | // The NAPI_VERSION supported by the runtime. This is the inclusive range of | |
0 commit comments