test_runner: do not error when getting `fullName` of root context · nodejs/node@e964c43 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 753
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e964c43

Browse filesBrowse the repository at this point in the historyBrowse files

Renegade334

authored and

targos

committed

test_runner: do not error when getting fullName of root context

PR-URL: #59377 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

1 parent 18a2ee5 commit e964c43
Copy full SHA for e964c43

2 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner
  • test.js
• test/parallel
  • test-runner-test-fullname.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/test.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/test.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1533,6 +1533,8 @@ class Suite extends Test {
1533	1533	}
1534	1534
1535	1535	function getFullName(test) {
	1536	+ if (test === test.root) return test.name;
	1537	+
1536	1538	let fullName = test.name;
1537	1539
1538	1540	for (let t = test.parent; t !== t.root; t = t.parent) {

Collapse file

‎test/parallel/test-runner-test-fullname.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-runner-test-fullname.js

+5-1Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,7 +1,11 @@
1	1	'use strict';
2	2	require('../common');
3	3	const { strictEqual } = require('node:assert');
4		- const { suite, test } = require('node:test');
	4	+ const { before, suite, test } = require('node:test');
	5	+
	6	+ before((t) => {
	7	+ strictEqual(t.fullName, '<root>');
	8	+ });
5	9
6	10	suite('suite', (t) => {
7	11	strictEqual(t.fullName, 'suite');

0 commit comments

Comments

0 (0)