Commit e9c6636
src: mark realm leaf classes final
Since these classes use virtual methods extensively, adding `final`
should allow compilers to optimize accesses better.
PR-URL: #59355
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 72cfff1 commit e9c6636
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -209,7 +209,7 @@ class Realm : public MemoryRetainer { | |||
| 209 | 209 | CppgcWrapperList cppgc_wrapper_list_; | |
| 210 | 210 | }; | |
| 211 | 211 | ||
| 212 | - class PrincipalRealm : public Realm { | ||
| 212 | + class PrincipalRealm final : public Realm { | ||
| 213 | 213 | public: | |
| 214 | 214 | PrincipalRealm(Environment* env, | |
| 215 | 215 | v8::Local<v8::Context> context, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,7 +9,7 @@ | |||
| 9 | 9 | namespace node { | |
| 10 | 10 | namespace shadow_realm { | |
| 11 | 11 | ||
| 12 | - class ShadowRealm : public Realm { | ||
| 12 | + class ShadowRealm final : public Realm { | ||
| 13 | 13 | public: | |
| 14 | 14 | static ShadowRealm* New(Environment* env); | |
| 15 | 15 | ||
0 commit comments