Commit e9e3306
test: use assert.{s,deepS}trictEqual()
Use `asset.strictEqual()` and `asset.deepStrictEqual()` in
`test/parallel/test-tls-set-sigalgs.js`.
PR-URL: #54208
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent 1320fb9 commit e9e3306
1 file changed
Lines changed: 10 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,13 +9,6 @@ const { | |||
| 9 | 9 | assert, connect, keys | |
| 10 | 10 | } = require(fixtures.path('tls-connect')); | |
| 11 | 11 | ||
| 12 | - function assert_arrays_equal(left, right) { | ||
| 13 | - assert.strictEqual(left.length, right.length); | ||
| 14 | - for (let i = 0; i < left.length; i++) { | ||
| 15 | - assert.strictEqual(left[i], right[i]); | ||
| 16 | - } | ||
| 17 | - } | ||
| 18 | - | ||
| 19 | 12 | function test(csigalgs, ssigalgs, shared_sigalgs, cerr, serr) { | |
| 20 | 13 | assert(shared_sigalgs || serr || cerr, 'test missing any expectations'); | |
| 21 | 14 | connect({ | |
@@ -43,16 +36,19 @@ function test(csigalgs, ssigalgs, shared_sigalgs, cerr, serr) { | |||
| 43 | 36 | assert.ifError(pair.client.err); | |
| 44 | 37 | assert(pair.server.conn); | |
| 45 | 38 | assert(pair.client.conn); | |
| 46 | - assert_arrays_equal(pair.server.conn.getSharedSigalgs(), shared_sigalgs); | ||
| 39 | + assert.deepStrictEqual( | ||
| 40 | + pair.server.conn.getSharedSigalgs(), | ||
| 41 | + shared_sigalgs | ||
| 42 | + ); | ||
| 47 | 43 | } else { | |
| 48 | 44 | if (serr) { | |
| 49 | 45 | assert(pair.server.err); | |
| 50 | - assert(pair.server.err.code, serr); | ||
| 46 | + assert.strictEqual(pair.server.err.code, serr); | ||
| 51 | 47 | } | |
| 52 | 48 | ||
| 53 | 49 | if (cerr) { | |
| 54 | 50 | assert(pair.client.err); | |
| 55 | - assert(pair.client.err.code, cerr); | ||
| 51 | + assert.strictEqual(pair.client.err.code, cerr); | ||
| 56 | 52 | } | |
| 57 | 53 | } | |
| 58 | 54 | ||
@@ -68,7 +64,9 @@ test('RSA-PSS+SHA256:RSA-PSS+SHA512:ECDSA+SHA256', | |||
| 68 | 64 | ||
| 69 | 65 | // Do not have shared sigalgs. | |
| 70 | 66 | test('RSA-PSS+SHA384', 'ECDSA+SHA256', | |
| 71 | - undefined, 'ECONNRESET', 'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITMS'); | ||
| 67 | + undefined, 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE', | ||
| 68 | + 'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITHMS'); | ||
| 72 | 69 | ||
| 73 | 70 | test('RSA-PSS+SHA384:ECDSA+SHA256', 'ECDSA+SHA384:RSA-PSS+SHA256', | |
| 74 | - undefined, 'ECONNRESET', 'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITMS'); | ||
| 71 | + undefined, 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE', | ||
| 72 | + 'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITHMS'); | ||
0 commit comments