Commit ea3d14e
committed
deps: remove problematic comment from v8-internal
GCC emits warnings because of the trailing backslashes.
PR-URL: #58070
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 6e5f3b9 commit ea3d14e
2 files changed
Lines changed: 1 addition & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.2', | ||
| 41 | + 'v8_embedder_string': '-node.3', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -434,19 +434,6 @@ constexpr size_t kMaxCppHeapPointers = 0; | |||
| 434 | 434 | // which all subtypes of a given supertype use contiguous tags. This struct can | |
| 435 | 435 | // then be used to represent such a type range. | |
| 436 | 436 | // | |
| 437 | - // As an example, consider the following type hierarchy: | ||
| 438 | - // | ||
| 439 | - // A F | ||
| 440 | - // / \ | ||
| 441 | - // B E | ||
| 442 | - // / \ | ||
| 443 | - // C D | ||
| 444 | - // | ||
| 445 | - // A potential type id assignment for range-based type checks is | ||
| 446 | - // {A: 0, B: 1, C: 2, D: 3, E: 4, F: 5}. With that, the type check for type A | ||
| 447 | - // would check for the range [A, E], while the check for B would check range | ||
| 448 | - // [B, D], and for F it would simply check [F, F]. | ||
| 449 | - // | ||
| 450 | 437 | // In addition, there is an option for performance tweaks: if the size of the | |
| 451 | 438 | // type range corresponding to a supertype is a power of two and starts at a | |
| 452 | 439 | // power of two (e.g. [0x100, 0x13f]), then the compiler can often optimize | |
0 commit comments