Commit eab5ef5
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.
Refs: https://stackoverflow.com/q/38378693
PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent d6e5dd5 commit eab5ef5
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.3', | ||
| 39 | + 'v8_embedder_string': '-node.4', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -60,7 +60,9 @@ class ScriptOriginOptions { | |||
| 60 | 60 | */ | |
| 61 | 61 | class V8_EXPORT ScriptOrigin { | |
| 62 | 62 | public: | |
| 63 | + #if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */ | ||
| 63 | 64 | V8_DEPRECATE_SOON("Use constructor with primitive C++ types") | |
| 65 | + #endif | ||
| 64 | 66 | ScriptOrigin( | |
| 65 | 67 | Local<Value> resource_name, Local<Integer> resource_line_offset, | |
| 66 | 68 | Local<Integer> resource_column_offset, | |
@@ -71,7 +73,9 @@ class V8_EXPORT ScriptOrigin { | |||
| 71 | 73 | Local<Boolean> is_wasm = Local<Boolean>(), | |
| 72 | 74 | Local<Boolean> is_module = Local<Boolean>(), | |
| 73 | 75 | Local<PrimitiveArray> host_defined_options = Local<PrimitiveArray>()); | |
| 76 | + #if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */ | ||
| 74 | 77 | V8_DEPRECATE_SOON("Use constructor that takes an isolate") | |
| 78 | + #endif | ||
| 75 | 79 | explicit ScriptOrigin( | |
| 76 | 80 | Local<Value> resource_name, int resource_line_offset = 0, | |
| 77 | 81 | int resource_column_offset = 0, | |
0 commit comments